Add JDBC transaction duration metrics#19003
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables recording of the stable db.client.operation.duration metric for JDBC transaction operations (e.g., COMMIT), aligning JDBC transaction instrumentation with the existing statement-level DB client metrics behavior.
Changes:
- Enabled DB client operation duration metrics on the JDBC transaction instrumenter.
- Added a regression test to assert
db.client.operation.durationis emitted for a transaction (commit) with the expected attribute keys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcInstrumenterFactory.java | Adds DbClientMetrics operation metrics to the transaction instrumenter so transaction spans contribute to db.client.operation.duration. |
| instrumentation/jdbc/library/src/test/java/io/opentelemetry/instrumentation/jdbc/datasource/JdbcTelemetryTest.java | Adds a test that exercises a transaction commit and asserts the stable DB client duration metric is emitted with expected attribute keys. |
jaydeluca
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary